fix: make compute_initialization_hash public again#11399
Closed
twt-- wants to merge 2 commits intoAztecProtocol:masterfrom
twt--:pub_compute_initialization_hash
Closed
fix: make compute_initialization_hash public again#11399twt-- wants to merge 2 commits intoAztecProtocol:masterfrom twt--:pub_compute_initialization_hash
twt-- wants to merge 2 commits intoAztecProtocol:masterfrom
twt--:pub_compute_initialization_hash
Conversation
benesjan
approved these changes
Jan 22, 2025
Contributor
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
Sorry for mindlessly hiding this from the public API.
Thanks for the fix
Contributor
|
@twt-- our CI is currently broken for external contributors so I am closing this and opening a duplicate under my name. |
auto-merge was automatically disabled
January 22, 2025 15:43
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_initialization_hashwas recently switched to private in #11129 efab709#diff-4ecf647dda8cae1b37fca32431de3d66507ea172383284deee8c4524cca9538bL63This PR makes it public again. I'm using it in my contracts to verify that contract instances were deployed with the expected arguments. If there is a better way to check that, please let me know and I'll switch to that instead.